[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add rofi.
From: |
Leo Famulari |
Subject: |
Re: [PATCH] gnu: Add rofi. |
Date: |
Mon, 23 May 2016 00:28:26 -0400 |
User-agent: |
Mutt/1.6.0 (2016-04-01) |
On Fri, May 20, 2016 at 06:29:52AM +0200, Danny Milosavljevic wrote:
> * gnu/packages/xdisorg.scm (rofi): New variable.
Thanks for the patch! I'd never heard of this program but as someone who
uses dmenu a lot, I'd like to try it out.
> +(define-public rofi
> + (uri (string-append
> "https://github.com/DaveDavenport/rofi/releases/download/" version "/rofi-"
> version ".tar.xz"))
Lines should be shorter than 80 characters whenever possible. `guix lint
rofi` should warn about this :)
> + (arguments
> + `(#:tests? #f))
The failing test (helper_expand) seems to fail when it can't find
`which`. There are examples of how to patch scripts with the path to our
`which` in gnu/packages. Can you try it out?
> + (synopsis "Application Launcher")
> + (description "Rofi is a minimalist Application Launcher. It memorizes
> which applications you regularily use and also allows you to search for an
> application by name.")
I think that "Launcher" should not start with a capital letter.
- [PATCH] gnu: Add rofi., Danny Milosavljevic, 2016/05/20
- Re: [PATCH] gnu: Add rofi.,
Leo Famulari <=
- Re: [PATCH] gnu: Add rofi., Danny Milosavljevic, 2016/05/24
- Re: [PATCH] gnu: Add rofi., Leo Famulari, 2016/05/24
- [PATCH v2] * gnu/packages/xdisorg.scm (rofi): New variable., Danny Milosavljevic, 2016/05/25
- Re: [PATCH v2] * gnu/packages/xdisorg.scm (rofi): New variable., Leo Famulari, 2016/05/27
- [PATCH v3] gnu: Add rofi., Danny Milosavljevic, 2016/05/27
- Re: [PATCH v3] gnu: Add rofi., Leo Famulari, 2016/05/27
- Re: [PATCH v3] gnu: Add rofi., Danny Milosavljevic, 2016/05/27
- Re: [PATCH v3] gnu: Add rofi., Leo Famulari, 2016/05/31