Re: [PATCH] Add vcflib.

[Ricardo Wurmus]

Roel Janssen <address@hidden> writes:

> Ricardo Wurmus writes:
>
>> Roel Janssen <address@hidden> writes:
>>
>>> Ricardo Wurmus writes:
>>>
>>>> Roel Janssen <address@hidden> writes:
>>>>
>>>>> From f0cb8c476e902e3351988f7c278b3682837c8cce Mon Sep 17 00:00:00 2001
>>>>> From: Roel Janssen <address@hidden>
>>>>> Date: Tue, 22 Mar 2016 15:47:06 +0100
>>>>> Subject: [PATCH 5/8] gnu: Add filevercmp.
>>>>
>>>>> * gnu/packages/bioinformatics.scm (filevercmp): New variable.

[...]

>> I see that my comment was ambiguous.  I meant the argument to
>> “(file-name ...)”.  Instead of using “filevercmp-src.tar.gz” I think it
>> would be better to include the generated version number by doing
>> something like this:
>>
>>     (file-name (string-append name "-" version ".tar.gz"))
>
> Oh, of course.  I attached an updated patch.

Pushed as 6b49a37.  Thanks!

~~ Ricardo