Re: [PATCH 02/04] gnu: xdotools: Update to 3.20150503.1

[Christopher Allan Webber]

Leo Famulari writes:

> On Sat, Feb 06, 2016 at 11:48:13AM -0800, Christopher Allan Webber wrote:
>> Leo Famulari writes:
>> > On Fri, Feb 05, 2016 at 07:48:12PM -0800, Christopher Allan Webber wrote:
>> > Is this line too long? I can't say for sure looking at the patch in my
>> > email client. If so, the linter should complain.
>> >
>> > [...]
>> 
>> You're right.  I should be using the linter but I was slacking off I
>> guess... sorry!
>
> The linter is our friend and we should visit him or her often :)

I agree.  I'll try to be more familiar with our linter friend more often!

> I do wonder about the tests... if the required "black magic" is having
> an X server available, we do have some examples of that in the package
> tree. Otherwise it might be good to explain a little more so that it's
> easier for future contributors to understand what the problem is.
>
> Otherwise LGTM.

Ah well... I didn't write this part about the tests!  And I don't know
the context.  I mostly just patched things up for the new version.

Anyway, since you say "LGTM", I'm going to merge this one.