[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Adding new information to scm_t_port (was Re: always O_BINARY?)
From: |
Mark H Weaver |
Subject: |
Re: Adding new information to scm_t_port (was Re: always O_BINARY?) |
Date: |
Tue, 05 Mar 2013 13:55:31 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Andy Wingo <address@hidden> writes:
> On Thu 28 Feb 2013 04:24, Mark H Weaver <address@hidden> writes:
>
>> Instead of having 'input_cd' and 'output_cd' point directly to the
>> platform's iconv_t structures, let's have them point to our own internal
>> structure(s) that hold the needed transcoder state. This could include
>> things like the state for internally-implement encoding(s) (e.g. UTF-8
>> BOM handling), EOL style, and iconv_t pointer(s) if appropriate.
>
> Great idea.
>
> I would call it a generic "port-private" data structure; it is not
> limited to transcoder state.
>
> struct scm_t_port_private;
> #define SCM_I_PORT_PRIVATE ((struct scm_t_port_private*)((ptob)->input_cd))
Sounds good to me. I'll include something like this in my next revision
of BOM-handling patches, which I hope to post soon.
Thanks,
Mark
- Re: Adding new information to scm_t_port (was Re: always O_BINARY?), Ludovic Courtès, 2013/03/01
- Re: Adding new information to scm_t_port (was Re: always O_BINARY?),
Mark H Weaver <=
- [PATCH] Add private port structure, and move iconv descriptors there, Mark H Weaver, 2013/03/27
- Re: [PATCH] Add private port structure, and move iconv descriptors there, Ludovic Courtès, 2013/03/27
- Re: [PATCH] Add private port structure, and move iconv descriptors there, Andy Wingo, 2013/03/27
- Re: [PATCH] Add private port structure, and move iconv descriptors there, Mark H Weaver, 2013/03/27
- [PATCH] Add internal-only port structure; move iconv descriptors there, Mark H Weaver, 2013/03/31
- Re: [PATCH] Add internal-only port structure; move iconv descriptors there, Ludovic Courtès, 2013/03/31
- Re: [PATCH] Add internal-only port structure; move iconv descriptors there, Mark H Weaver, 2013/03/31
- Re: [PATCH] Add internal-only port structure; move iconv descriptors there, Ludovic Courtès, 2013/03/31
- Re: [PATCH] Add private port structure, and move iconv descriptors there, Mark H Weaver, 2013/03/31
- Re: [PATCH] Add private port structure, and move iconv descriptors there, Ludovic Courtès, 2013/03/31