[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Adding new information to scm_t_port (was Re: always O_BINARY?)
From: |
Ludovic Courtès |
Subject: |
Re: Adding new information to scm_t_port (was Re: always O_BINARY?) |
Date: |
Fri, 01 Mar 2013 10:03:16 +0100 |
User-agent: |
Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) |
Andy Wingo <address@hidden> skribis:
> On Thu 28 Feb 2013 12:04, address@hidden (Ludovic Courtès) writes:
>
>> Andy Wingo <address@hidden> skribis:
>>
>>> On Thu 28 Feb 2013 04:24, Mark H Weaver <address@hidden> writes:
>>>
>>>> Instead of having 'input_cd' and 'output_cd' point directly to the
>>>> platform's iconv_t structures, let's have them point to our own internal
>>>> structure(s) that hold the needed transcoder state. This could include
>>>> things like the state for internally-implement encoding(s) (e.g. UTF-8
>>>> BOM handling), EOL style, and iconv_t pointer(s) if appropriate.
>>>
>>> Great idea.
>>>
>>> I would call it a generic "port-private" data structure; it is not
>>> limited to transcoder state.
>>>
>>> struct scm_t_port_private;
>>> #define SCM_I_PORT_PRIVATE ((struct
>>> scm_t_port_private*)((ptob)->input_cd))
>>
>> Sounds good to me, perhaps with ‘input_cd’ changed to ‘internal’ or
>> similar.
>
> That would be an API break; probably best to keep it with the same name,
> no? Though I guess it doesn't matter in this particular case...
I’d say it doesn’t matter in this case because I can hardly imagine
someone doing something useful with ‘input_cd’ outside of Guile.
Ludo’.
- Re: Adding new information to scm_t_port (was Re: always O_BINARY?),
Ludovic Courtès <=
- Re: Adding new information to scm_t_port (was Re: always O_BINARY?), Mark H Weaver, 2013/03/05
- [PATCH] Add private port structure, and move iconv descriptors there, Mark H Weaver, 2013/03/27
- Re: [PATCH] Add private port structure, and move iconv descriptors there, Ludovic Courtès, 2013/03/27
- Re: [PATCH] Add private port structure, and move iconv descriptors there, Andy Wingo, 2013/03/27
- Re: [PATCH] Add private port structure, and move iconv descriptors there, Mark H Weaver, 2013/03/27
- [PATCH] Add internal-only port structure; move iconv descriptors there, Mark H Weaver, 2013/03/31
- Re: [PATCH] Add internal-only port structure; move iconv descriptors there, Ludovic Courtès, 2013/03/31
- Re: [PATCH] Add internal-only port structure; move iconv descriptors there, Mark H Weaver, 2013/03/31
- Re: [PATCH] Add internal-only port structure; move iconv descriptors there, Ludovic Courtès, 2013/03/31
- Re: [PATCH] Add private port structure, and move iconv descriptors there, Mark H Weaver, 2013/03/31