Re: bug in sort.c

[Marius Vollmer]

Roland Orre <address@hidden> writes:

> The following two lines in scm_restricted_vector_sort_x
> are wrong:
>
>   SCM_VALIDATE_INUM_RANGE (4, endpos,0, vlen+1);
>   len = SCM_INUM (endpos) - spos;
>
> they should be:
>
>   SCM_VALIDATE_INUM_RANGE (4, endpos,0, vlen);
>   len = SCM_INUM (endpos) - spos + 1;

I think the code is correct: we need to have

    0 <= startpos <= endpos <= vlen

The element with index endpos is not included in the sort, thus we
will sort

    len = endpos - spos

elements.

The docstring needs to be clearer about this, tho.