[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: RFC: major change to argument processing.
From: |
Marius Vollmer |
Subject: |
Re: RFC: major change to argument processing. |
Date: |
02 Jun 2001 13:08:58 +0200 |
User-agent: |
Gnus/5.09 (Gnus v5.9.0) Emacs/21.0.102 |
Rob Browning <address@hidden> writes:
> Marius Vollmer <address@hidden> writes:
>
> I think the code should be pretty easy to follow, though. I did have
> to add more code to handle unexpected eof's *everywhere*,
I think I also treat eofs everywhere, no?
> and I tried to avoid any "reversing" (though there was no really
> good reason for that since performance doesn't really matter here).
Instead of reversing, you recurse. I'd say that this is actually
worse than reversing... ;>
> In any case, I'd be happy to use code more like yours if you'd
> prefer that, but here's what I currently have:
Whichever you like better. I don't think there is any difference
between the two, except that you rely on left-to-right evaluation when
recursing (which you shouldn't do) and that you return an empty string
at eof, which might be better flagged by the the-eof-object. I use
`eq?' to compare characters, but I should really be using `char=?'.
The original code in script.c also does backslash expansion, as I
noticed now. That is, "\n" is replaced by linefeed, etc. The shell
doesn't do this, and we shouldn't either, I think.
- Re: RFC: major change to argument processing., Dirk Herrmann, 2001/06/01
- Re: RFC: major change to argument processing., Lars J. Aas, 2001/06/01
- Re: RFC: major change to argument processing., Dirk Herrmann, 2001/06/01
- Re: RFC: major change to argument processing., Marius Vollmer, 2001/06/01
- Re: RFC: major change to argument processing., Rob Browning, 2001/06/01
- Re: RFC: major change to argument processing., Marius Vollmer, 2001/06/01
- Re: RFC: major change to argument processing., Rob Browning, 2001/06/02
- Re: RFC: major change to argument processing.,
Marius Vollmer <=
- Re: RFC: major change to argument processing., Rob Browning, 2001/06/02
- Re: RFC: major change to argument processing., Marius Vollmer, 2001/06/02
- Re: RFC: major change to argument processing., Rob Browning, 2001/06/02
- Re: RFC: major change to argument processing., Marius Vollmer, 2001/06/02
- Re: RFC: major change to argument processing., Rob Browning, 2001/06/02