guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

configure.in change people should check.


From: Rob Browning
Subject: configure.in change people should check.
Date: 02 Jun 2001 00:26:13 -0500
User-agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7

Autoconf has changed how it handles struct members.  For most things
you're supposed to use AC_CHECK_MEMBERS, so I've fixed that.  However,
I also changed our st_blocks to just use the standard
AC_STRUCT_ST_BLOCKS test.  Unless there's a strong argument against
that, it seems like a good idea so that we'll pick up upstream
autoconf improvements.  However, if that was a bad idea (which didn't
seem clear from the comment), then please reverse the change, or let
me know and I'll reverse it (once I get it committed).

Here's the relevant diff section:

  -AC_STRUCT_ST_RDEV
  -AC_STRUCT_ST_BLKSIZE
  +AC_CHECK_MEMBERS([struct stat.st_rdev])
  +AC_CHECK_MEMBERS([struct stat.st_blksize])

  -# We could use AC_STRUCT_ST_BLOCKS here, but that adds fileblocks.o to
  -# LIBOBJS, which we don't need.  This seems more direct.
  -AC_CACHE_CHECK([for st_blocks in struct stat], ac_cv_struct_st_blocks,
  -[AC_TRY_COMPILE([#include <sys/types.h>
  -#include <sys/stat.h>], [struct stat s; s.st_blocks;],
  -ac_cv_struct_st_blocks=yes, ac_cv_struct_st_blocks=no)])
  -if test $ac_cv_struct_st_blocks = yes; then
  -  AC_DEFINE(HAVE_ST_BLOCKS)
  -fi
  +AC_STRUCT_ST_BLOCKS

-- 
Rob Browning <address@hidden> PGP=E80E0D04F521A094 532B97F5D64E3930



reply via email to

[Prev in Thread] Current Thread [Next in Thread]