[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] net: Fix incorrect condition for calling grub_net_tcp_retransmit

From: Glenn Washburn
Subject: [PATCH] net: Fix incorrect condition for calling grub_net_tcp_retransmit()
Date: Wed, 11 May 2022 21:44:01 -0500

The commit 848724273e4 (net/net: Avoid unnecessary calls to
grub_net_tcp_retransmit()) needs to have its condition inverted to avoid
unnecessary calls to grub_net_tcp_retransmit(). As it is, it creates many
unnecessary calls and does not call grub_net_tcp_retransmit() when needed.
The call to grub_net_tcp_retransmit() should only be made when
grub_net_cards does _not_ equal NULL, meaning that there are potentially
network cards that need tcp retransmission.

Signed-off-by: Glenn Washburn <>
 grub-core/net/net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/grub-core/net/net.c b/grub-core/net/net.c
index 88ea49fee..2b6771523 100644
--- a/grub-core/net/net.c
+++ b/grub-core/net/net.c
@@ -1634,7 +1634,7 @@ grub_net_poll_cards_idle_real (void)
        || ctime >= card->last_poll + card->idle_poll_delay_ms)
       receive_packets (card, 0);
-  if (grub_net_cards == NULL)
+  if (grub_net_cards != NULL)
     grub_net_tcp_retransmit ();

reply via email to

[Prev in Thread] Current Thread [Next in Thread]