[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] net: Fix incorrect condition for calling grub_net_tcp_retran

From: Daniel Kiper
Subject: Re: [PATCH] net: Fix incorrect condition for calling grub_net_tcp_retransmit()
Date: Tue, 17 May 2022 16:51:04 +0200
User-agent: NeoMutt/20170113 (1.7.2)

On Wed, May 11, 2022 at 09:44:01PM -0500, Glenn Washburn wrote:
> The commit 848724273e4 (net/net: Avoid unnecessary calls to
> grub_net_tcp_retransmit()) needs to have its condition inverted to avoid
> unnecessary calls to grub_net_tcp_retransmit(). As it is, it creates many
> unnecessary calls and does not call grub_net_tcp_retransmit() when needed.
> The call to grub_net_tcp_retransmit() should only be made when
> grub_net_cards does _not_ equal NULL, meaning that there are potentially
> network cards that need tcp retransmission.
> Signed-off-by: Glenn Washburn <>

Reviewed-by: Daniel Kiper <>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]