[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Re: [PATCH v2] net: fix null pointer dereference when parsing ICMP6_
Re: Re: [PATCH v2] net: fix null pointer dereference when parsing ICMP6_ROUTER_ADVERTISE messages
Thu, 21 Apr 2022 19:39:07 +0200
On Thu, Apr 21, 2022 at 01:56:35PM +0000, zhangqiumiao via Grub-devel wrote:
> On Thu, Apr 21, 2022 at 21:41:52PM +0800, Daniel Kiper wrote:
> > On Sat, Apr 16, 2022 at 09:50:11AM +0800, Qiumiao Zhang via Grub-devel
> > wrote:
> > > During UEFI PXE boot in IPv6 network, if the DHCP server adopts
> > > stateful automatic configuration, then the client receives a
> > > ICMP6_ROUTER_ADVERTISE multicast message from the server. This may be
> > > received without the interfaced having a configured network address,
> > > so orig_inf will be null, which can lead to a null dereference when
> > > creating the default route. Actually, in this case, the client obtains
> > > the default route through DHCPv6 instead of RA messages. So if
> > > orig_inf == NULL and route_inf == null, we should not set the default
> > > route.
> > >
> > > Fixes bug: https://savannah.gnu.org/bugs/index.php?62072
> > Missing "Signed-off-by: Qiumiao Zhang <firstname.lastname@example.org>" line.
> > May I add it on behalf of you?
> Yes, that's perfect.
Cool! Thank you for fixing this!