[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] net: fix null pointer dereference when parsing ICMP6_ROUT
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH v2] net: fix null pointer dereference when parsing ICMP6_ROUTER_ADVERTISE messages |
|
Date: |
Thu, 21 Apr 2022 15:40:47 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Sat, Apr 16, 2022 at 09:50:11AM +0800, Qiumiao Zhang via Grub-devel wrote:
> During UEFI PXE boot in IPv6 network, if the DHCP server adopts
> stateful automatic configuration, then the client receives a
> ICMP6_ROUTER_ADVERTISE multicast message from the server. This may be
> received without the interfaced having a configured network address,
> so orig_inf will be null, which can lead to a null dereference when
> creating the default route. Actually, in this case, the client obtains
> the default route through DHCPv6 instead of RA messages. So if
> orig_inf == NULL and route_inf == null, we should not set the default
> route.
>
> Fixes bug: https://savannah.gnu.org/bugs/index.php?62072
Missing "Signed-off-by: Qiumiao Zhang <zhangqiumiao1@huawei.com>" line.
May I add it on behalf of you?
Otherwise Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel