Re: [PATCH 2/2] tests: Give grub-fs-tester temp directory a better name

[Daniel Kiper]

On Sat, Apr 09, 2022 at 02:44:47AM +0000, Glenn Washburn wrote:
> Instead of "tmp" the name is prefixed by the name of the scripts (eg.
> grub-fs-tester). A timestamp is added in the name to allow for easily
> seeing a chronological sorting of runs and the name of the filesystem
> being tested. The random component is set to the minimal possible, 3
> characters, because the timestamp should provide enough uniqueness.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
> ---
>  tests/util/grub-fs-tester.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in
> index 868199109f..02edcf897f 100644
> --- a/tests/util/grub-fs-tester.in
> +++ b/tests/util/grub-fs-tester.in
> @@ -7,7 +7,7 @@ fs="$1"
>
>  GRUBFSTEST="@builddir@/grub-fstest"
>
> -tempdir=`mktemp -d "${TMPDIR:-/tmp}/tmp.XXXXXXXXXX"` ||
> +tempdir=`mktemp -d "${TMPDIR:-/tmp}/${0##*/}.$(date 
> '+%Y%m%d%H%M%S%N').${fs}.XXX"` ||

I would just s/XXX/tmp/. Otherwise LGTM...

For both patches Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel