Re: [PATCH v2 0/1] plainmount: Support plain encryption mode.

[Daniel Kiper]

Hi Maxim,

Adding Glenn and Patrick. I would like to hear your opinion here.

Maxim, please CC Glenn and Patrick next time.

Daniel

PS Maxim, It looks you send the patch as an cover letter. Minor
   thing but a little annoying.

On Sat, Apr 02, 2022 at 08:00:20PM +0000, Maxim Fomin wrote:
> This patch adds support for plain encryption mode (plain dm-crypt) via
> new module/command named 'plainmount'. This is the second version of the
> patch send at 
> https://lists.gnu.org/archive/html/grub-devel/2022-01/msg00179.html.
>
> The patch was significantly rewritten. Notable changes are:
> 1. removing UUID code - UUID path can be supported by other grub tools
> (grub probe and search), thus avoiding code duplication.
>
> 2. option -p (specify password, usefull for testing) was added as an
> alternative for console interactive password prompt.
>
> 3. K/M/G offset suffix support was added - previously offsets were
> specified as 512 byte blocks.
>
> 4. removed grub_print_error() inside plainmount internal functions -
> all errors are reported when grub command exits.
>
> 5. other minor coding changes. Error handling in cryptodisk_setkey() was
> refactored in dedicated function in order to handle GPG errors uniformly.
> However, the way GPG errors are handled was not changed due to reasons
> mentioned in previous discussion. Option -Z (sector size) was renamed to
> -S. Also, unique cryptodisk UUIDs were added.
>
> Maxim Fomin (1):
>   plainmount: Support plain encryption mode.
>
>  docs/grub.texi              |  47 ++++
>  grub-core/Makefile.core.def |   5 +
>  grub-core/disk/plainmount.c | 511 ++++++++++++++++++++++++++++++++++++
>  3 files changed, 563 insertions(+)
>  create mode 100644 grub-core/disk/plainmount.c
>
> --
> 2.35.1