[PATCH v2 0/8] Various fixes/improvements for tests

[Glenn Washburn]

This is an update to the first version of this patch series to account for
changes in tests/ahci_test.in which cause a conflict in the previous patch
series. Nothing of substance has changed which would invalidate the previous
cover letter, to which I'll refer for comments on the patches.

Glenn

Glenn Washburn (8):
  tests: Make sure LANG is set properly for iso9660_test
  tests: Fix partmap_test for arm*-efi, disk numbering has changed
  tests: When checking squashfs fstime, use superblock last modified
    time
  tests: Fail immediately when grub-shell fails and do not occlude the
    error code
  tests: Make setup errors in grub-fs-tester hard errors
  tests: A failure of mktemp should cause the test script to exit with
    code 99
  tests: Exit with skipped exit code when test not performed
  tests: Use @BUILD_SHEBANG@ autoconf var instead of literal shell

 tests/ahci_test.in             | 18 +++++++++++-------
 tests/cdboot_test.in           | 11 ++++++-----
 tests/core_compress_test.in    |  8 +++++---
 tests/ehci_test.in             | 18 +++++++++++-------
 tests/f2fs_test.in             |  2 +-
 tests/fddboot_test.in          | 19 ++++++++++---------
 tests/gettext_strings_test.in  |  2 +-
 tests/grub_cmd_date.in         |  5 +++--
 tests/grub_cmd_set_date.in     |  6 +++---
 tests/grub_cmd_test.in         |  7 ++++---
 tests/grub_script_blockarg.in  |  4 ++--
 tests/grub_script_expansion.in |  3 ++-
 tests/gzcompress_test.in       |  3 ++-
 tests/hddboot_test.in          |  9 +++++----
 tests/iso9660_test.in          |  6 ++++++
 tests/lzocompress_test.in      |  3 ++-
 tests/netboot_test.in          | 15 ++++++++-------
 tests/ohci_test.in             | 18 +++++++++++-------
 tests/partmap_test.in          | 18 +++++++++---------
 tests/pata_test.in             | 13 +++++++------
 tests/pseries_test.in          |  2 +-
 tests/syslinux_test.in         |  2 +-
 tests/test_sha512sum.in        |  7 ++++---
 tests/uhci_test.in             | 18 +++++++++++-------
 tests/util/grub-fs-tester.in   | 17 ++++++++++++-----
 tests/xzcompress_test.in       |  3 ++-
 26 files changed, 140 insertions(+), 97 deletions(-)

Range-diff against v1:
1:  c1ff77eec = 1:  17ddccb2e tests: Make sure LANG is set properly for 
iso9660_test
2:  eb4bf8cb6 = 2:  62ed781c8 tests: Fix partmap_test for arm*-efi, disk 
numbering has changed
3:  b00c1df00 = 3:  066486e22 tests: When checking squashfs fstime, use 
superblock last modified time
4:  73f81a5b4 ! 4:  562d74a49 tests: Fail immediately when grub-shell fails and 
do not occlude the error code
    @@ tests/ahci_test.in: echo "hello" > "$outfile"
      
      tar cf "$imgfile" "$outfile"
      
    --if [ "$(echo "nativedisk; source '(ahci0)/$outfile';" | "${grubshell}" 
--qemu-opts="-drive id=disk,file=$imgfile,if=none -device ahci,id=ahci -device 
ide-drive,drive=disk,bus=ahci.0 " | tail -n 1)" != "Hello World" ]; then
    +-if [ "$(echo "nativedisk; source '(ahci0)/$outfile';" | "${grubshell}" 
--qemu-opts="-drive id=disk,file=$imgfile,if=none -device ahci,id=ahci -device 
ide-hd,drive=disk,bus=ahci.0 " | tail -n 1)" != "Hello World" ]; then
     +echo "nativedisk; source '(ahci0)/$outfile';" |
     +    "${grubshell}" --qemu-opts="-drive id=disk,file=$imgfile,if=none
     +                          -device ahci,id=ahci
    -+                          -device ide-drive,drive=disk,bus=ahci.0" 
>$outfile
    ++                          -device ide-hd,drive=disk,bus=ahci.0" >$outfile
     +if [ "$(cat "$outfile" | tail -n 1)" != "Hello World" ]; then
         rm "$imgfile"
         rm "$outfile"
5:  946730f71 = 5:  af85ae97f tests: Make setup errors in grub-fs-tester hard 
errors
6:  0e49be59e = 6:  fcb2b7a06 tests: A failure of mktemp should cause the test 
script to exit with code 99
7:  f08c84e58 = 7:  47afc3569 tests: Exit with skipped exit code when test not 
performed
8:  dca75ed56 = 8:  40f77d41b tests: Use @BUILD_SHEBANG@ autoconf var instead 
of literal shell
-- 
2.27.0