Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test

[Glenn Washburn]

On Thu, 26 Aug 2021 08:53:31 +0200
"Thomas Schmitt" <scdbackup@gmx.net> wrote:

> Hi,
> 
> Glenn Washburn wrote:
> >  Despite having an alternative approach, do you have concerns or
> > objections to my patch?
> 
> Not specifically. I initially only wanted to mention that there is
> a xorriso alternative to setting LANG. Both ways have different
> implications in detail. (LANG is global to the test code. The
> xorriso charset commands would affect only the xorriso run.)
> 
> But my attempt to reproduce the problem failed and i do not yet know
> why exactly your xorriso run had conversion problems although no
> explicit character set conversion was demanded. So i hoped for an
> enlightening error message.

Nope, no error message, I believe xorriso is working as intended.

Did you verify that running the test with LANG=, as I suggested in my
prior email, did indeed fail? I have attached an output log of the
iso9660_test failure. You can see that the file
"éàèüöäëñкирилица䏌䐓䏕Ελληνικά䏌䐓䏕" was converted to
"__________________________________________________________________".


Here is the argv array according to strace:
["xorriso", "--rockridge", "off", "-compliance", "rec_mtime", "-as",
"mkisofs", "-iso-level", "3", "-graft-points", "-J", "-joliet-long",
"-V",
"g;/_\303\251\344\217\214\344\220\223\344\217\225\344\216\233\344\216\276\344\217\264\320\272\320\270\321\202
u", "--modification-date=2021082616575500", "-o",
"/media/tmpfs/bootloader/testtmp/tmp.gZvxe3D0aH/joliet_512_512_1_0.img",
"/=/media/tmpfs/bootloader/testtmp/tmp.gZvxe3D0aH/master"]

> > So unless I'm
> > mistaken, you are confirming the issue this patch resolves.
> 
> It happens only if i tell xorriso explicitely that it shall convert to
> UTF-8. In the next step it vanishes when i also tell xorriso to also
> convert from UTF-8.

I missed that in the previous email. The biggest difference I see with
the grub test is that its getting the non-ASCII filename from the file
system and not being passed in as a commandline arg explicitly.

Glenn

iso9660_test.log
Description: Text Data