Re: [PATCH 0/3] A few small OpenBSD-ish fixes

[Daniel Kiper]

Hi Jacob,

On Tue, May 18, 2021 at 10:14:12PM -0700, jacob berkman wrote:
> Hello,
>
> I built GRUB on OpenBSD 6.9 over the weekend, and ran into a few
> issues. The minor ones attached were easy enough to
> fix. Unfortunately, once installed, it merely prints "Grub Loading"
> (or something similar) and reboots. In trying to recover from this, I
> wiped out the MBR and that's when I gave up and figured maybe I should
> do this in a VM instead.

The patches look more or less good to me. Though I would like to ask you
to add to all of them your SOB line like:

Signed-off-by: jacob berkman <jacob@87k.net>

Additionally, please do not put whole description of the issue into the
subject. The subject should contain only a hint what a given patch does.

> One other issue I ran into was that setjmp.mod would fail to build
> because it didn't export any symbols. No other modules seemed to
> depend on it. I just removed it from Makefile, but I'm not familiar
> enough with GRUB to know whether that's a reasonable enough solution,
> or if that's related to the inability to boot.

Could you provide more details how to reproduce the issue?

Daniel