[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] grub-core: Build fixes for i386
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH v3] grub-core: Build fixes for i386 |
|
Date: |
Thu, 27 May 2021 16:43:40 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Wed, May 26, 2021 at 08:18:24PM +0200, Jan (janneke) Nieuwenhuizen wrote:
> This fixes cross-compiling to x86 (e.g., the Hurd) from x86-linux of
>
> grub-core/lib/i386/relocator64.S
>
> This file has six sections that only build with a 64-bit assembler,
> yet only the first two sections had support for a 32-bit assembler;
> this patch completes this for the remaining sections.
>
> To reproduce, update the GRUB source description in your local Guix
> archive and run
>
> ./pre-inst-env guix build --system=i686-linux --target=i586-pc-gnu grub
>
> or install an x86 cross-build environment on x86-linux (32-bit!) and
> configure to cross build and make, e.g., do something like
>
> ./configure \
> CC_FOR_BUILD=gcc \
> --build=i686-unknown-linux-gnu \
> --host=i586-pc-gnu
> make
>
> Signed-off-by: Jan (janneke) Nieuwenhuizen <janneke@gnu.org>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com> except these "empty"
line changes. Though I will fix them before committing...
Thank you for fixing this issue...
Daniel