[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] kern/misc: Move grub_printf_fmt_check to gfxmenu
|
From: |
Thomas Frauendorfer |
|
Subject: |
Re: [PATCH] kern/misc: Move grub_printf_fmt_check to gfxmenu |
|
Date: |
Mon, 22 Mar 2021 08:35:32 +0100 |
On Sat, Mar 20, 2021 at 1:22 AM Colin Watson <cjwatson@debian.org> wrote:
>
> This function is only used by gfxmenu. Moving it there is unfortunately
> a bit messy, but it frees up a fairly substantial amount (in relative
> terms) of precious core image space on i386-pc.
>
> DOWN: obj/i386-pc/grub-core/kernel.img (31740 > 31528) - change: -212
> UP: obj/i386-pc/grub-core/gfxmenu.mod (39816 < 40216) - change: 400
> DOWN: i386-pc core image (biosdisk ext2 part_msdos) (27453 > 27351) -
> change: -102
> DOWN: i386-pc core image (biosdisk ext2 part_msdos diskfilter mdraid09)
> (32367 > 32259) - change: -108
Thank you for the size analysis. Size constraints on i386-pc was
something I had not considered when I wrote the original patch.