[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 03/17] luks2: Remove unused argument in grub_error
From: |
Patrick Steinhardt |
Subject: |
Re: [PATCH v7 03/17] luks2: Remove unused argument in grub_error |
Date: |
Sun, 6 Dec 2020 14:25:06 +0100 |
On Fri, Dec 04, 2020 at 10:43:32AM -0600, Glenn Washburn wrote:
> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Patrick Steinhardt <ps@pks.im>
> ---
> grub-core/disk/luks2.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/grub-core/disk/luks2.c b/grub-core/disk/luks2.c
> index d96764a02..bdb90e4b6 100644
> --- a/grub-core/disk/luks2.c
> +++ b/grub-core/disk/luks2.c
> @@ -200,7 +200,7 @@ luks2_parse_segment (grub_luks2_segment_t *out, const
> grub_json_t *segment)
> grub_json_getstring (&out->size, segment, "size") ||
> grub_json_getstring (&out->encryption, segment, "encryption") ||
> grub_json_getint64 (&out->sector_size, segment, "sector_size"))
> - return grub_error (GRUB_ERR_BAD_ARGUMENT, "Missing segment parameters",
> type);
> + return grub_error (GRUB_ERR_BAD_ARGUMENT, "Missing segment parameters");
>
> return GRUB_ERR_NONE;
> }
> @@ -228,7 +228,7 @@ luks2_parse_digest (grub_luks2_digest_t *out, const
> grub_json_t *digest)
>
> if (grub_json_getsize (&size, &segments))
> return grub_error (GRUB_ERR_BAD_ARGUMENT,
> - "Digest references no segments", type);
> + "Digest references no segments");
>
> for (i = 0; i < size; i++)
> {
> @@ -240,7 +240,7 @@ luks2_parse_digest (grub_luks2_digest_t *out, const
> grub_json_t *digest)
>
> if (grub_json_getsize (&size, &keyslots))
> return grub_error (GRUB_ERR_BAD_ARGUMENT,
> - "Digest references no keyslots", type);
> + "Digest references no keyslots");
>
> for (i = 0; i < size; i++)
> {
> --
> 2.27.0
>
signature.asc
Description: PGP signature
- [PATCH v7 13/17] luks2: Error check segment.sector_size, (continued)
- [PATCH v7 13/17] luks2: Error check segment.sector_size, Glenn Washburn, 2020/12/04
- [PATCH v7 08/17] cryptodisk: Add macro GRUB_TYPE_BITS() to replace some literals, Glenn Washburn, 2020/12/04
- [PATCH v7 06/17] luks2: Use more intuitive slot key instead of index in user messages, Glenn Washburn, 2020/12/04
- [PATCH v7 03/17] luks2: Remove unused argument in grub_error, Glenn Washburn, 2020/12/04
- [PATCH v7 17/17] luks2: Use grub_log2ull to calculate log_sector_size and improve readability, Glenn Washburn, 2020/12/04
- [PATCH v7 02/17] misc: Add parentheses around ALIGN_UP and ALIGN_DOWN arguments, Glenn Washburn, 2020/12/04
- [PATCH v7 05/17] luks2: Add json_slot_key member to struct grub_luks2_keyslot/segment/digest, Glenn Washburn, 2020/12/04