Re: [PATCH v7 03/17] luks2: Remove unused argument in grub_error

[Patrick Steinhardt]

On Tue, Dec 08, 2020 at 11:45:37AM -0600, Glenn Washburn wrote:
> On Mon, 7 Dec 2020 20:52:44 +0100
> Daniel Kiper <dkiper@net-space.pl> wrote:
> 
> > On Fri, Dec 04, 2020 at 10:43:32AM -0600, Glenn Washburn wrote:
> > > Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
> > > Signed-off-by: Glenn Washburn <development@efficientek.com>
> > 
> > Nit, my RB should be after your SOB. I will fix it.
> > 
> > Daniel
> 
> This is annoying to do with how my git is setup, which is to
> automatically append my SOB when doing format-patch.  Do you just do
> SOBs and RBs by hand, or have a way to do this more automatically?
> 
> Glenn

You can for example just use `git commit --signoff` when creating the
commit. There's also `git rebase --signoff` to add SOBs for rebased
patches if they don't have one yet. If RBs come in during review, I
typically just `git rebase --interactive` and `r` commits to add the
trailing RBs.

Patrick

signature.asc
Description: PGP signature