Re: [PATCH] Don't run f2fs test on systems with PAGE_SIZE > 4KB

[Daniel Kiper]

On Sun, Apr 26, 2020 at 12:53:35AM -0400, Mike Gilbert wrote:
> On Thu, Apr 23, 2020 at 5:10 AM Anatoly Pugachev <address@hidden> wrote:
> >
> > On Tue, Jul 30, 2019 at 3:10 PM Anatoly Pugachev <address@hidden> wrote:
> > >
> > > On Tue, Jul 30, 2019 at 1:00 PM John Paul Adrian Glaubitz
> > > <address@hidden> wrote:
> > > > On 7/30/19 10:11 AM, Anatoly Pugachev wrote:
> > > > > don't run f2fs test on systems with PAGE_SIZE > 4096 bytes.
> > > > > Since f2fs is not supported on this systems (can't mount f2fs 
> > > > > filesystem).
> > > >
> > > > Some spelling fixes and re-phrasing suggestion:
> > > >
> > > > > Don't run f2fs tests on systems with PAGE_SIZE > 4096 bytes since f2fs
> > > > > is not supported on these systems and mounting a f2fs filesystems 
> > > > > fails.
> > > >
> > > > And:
> > > >
> > > > +PAGE_SIZE=$(getconf PAGE_SIZE)
> > > > +F2FS_BLKSIZE=4096
> > > > +if [ $PAGE_SIZE > $F2FS_BLKSIZE ]; then
>
> This code does not do what you think it does. It runs the command "[
> $PAGE_SIZE" and pipes the output to a file called "4096". The
> resulting status will always be 0 (success).
>
> You probably want to use "-gt" in place of ">".
>
> if [ $PAGE_SIZE -gt $F2FS_BLKSIZE ]; then

Ugh... Good point! I missed that somehow.

Anatoly, please take into account Mike's and mine comments and repost
the patch.

Daniel