grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] mips/cache: Add missing nop's in delay slots


From: Vladimir 'phcoder' Serbinenko
Subject: [PATCH] mips/cache: Add missing nop's in delay slots
Date: Mon, 27 Apr 2020 17:31:46 +0200

Lack of them causes random instructions to be  executed before the
jump really happens.

Signed-off-by: Vladimir Serbinenko <address@hidden>
---
 grub-core/kern/mips/cache.S | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/grub-core/kern/mips/cache.S b/grub-core/kern/mips/cache.S
index fa6897e14..fa331eca1 100644
--- a/grub-core/kern/mips/cache.S
+++ b/grub-core/kern/mips/cache.S
@@ -7,6 +7,7 @@
 FUNCTION (grub_arch_sync_caches)
 #include "cache_flush.S"
  j $ra
+ nop

 FUNCTION (grub_arch_sync_dma_caches)
  move $t2, $a0
@@ -66,3 +67,4 @@ FUNCTION (grub_arch_sync_dma_caches)
  sync_op

  jr $ra
+ nop
-- 
2.20.1


-- 
Regards
Vladimir 'phcoder' Serbinenko



reply via email to

[Prev in Thread] Current Thread [Next in Thread]