[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: OBP available region patch fails with clang
|
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
|
Subject: |
Re: OBP available region patch fails with clang |
|
Date: |
Wed, 24 Feb 2016 20:13:50 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 |
On 24.02.2016 18:35, Andrei Borzenkov wrote:
> kern/ieee1275/mmap.c:52:22: error: comparison of integers of different
> signs: 'grub_ssize_t'
> (aka 'int') and 'unsigned int' [-Werror,-Wsign-compare]
> if (available_size > sizeof (available))
> ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~
> 1 error generated.
>
> While we can of course cast to (grub_ssize_t) sizeof (available) -
> should not we check for available_size < 0 as well?
>
I have fixed it locally but forgot to push
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
signature.asc
Description: OpenPGP digital signature