grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

OBP available region patch fails with clang


From: Andrei Borzenkov
Subject: OBP available region patch fails with clang
Date: Wed, 24 Feb 2016 20:35:33 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

kern/ieee1275/mmap.c:52:22: error: comparison of integers of different
signs: 'grub_ssize_t'
      (aka 'int') and 'unsigned int' [-Werror,-Wsign-compare]
  if (available_size > sizeof (available))
      ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~
1 error generated.

While we can of course cast to (grub_ssize_t) sizeof (available) -
should not we check for available_size < 0 as well?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]