[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] efidisk: prevent errors from diskfilter scan of removable dr
|
From: |
Andrei Borzenkov |
|
Subject: |
Re: [PATCH] efidisk: prevent errors from diskfilter scan of removable drives |
|
Date: |
Fri, 12 Feb 2016 17:38:58 +0300 |
On Fri, Feb 12, 2016 at 5:29 PM, Vladimir 'φ-coder/phcoder' Serbinenko
<address@hidden> wrote:
> On 05.02.2016 17:56, Andrei Borzenkov wrote:
>> Map EFI_NO_MEDIA to GRUB_ERR_OUT_OF_RANGE that is ignored by diskfilter. This
>> actually matches pretty close (we obviously attempt to read outside of media)
>> and avoids adding more error codes.
>>
>> This affects only internally initiated scans. If read/write from removable is
>> explicitly requested, we still return an error and text explanation is more
>> clear for user than generic error.
>>
>> Reported and tested by Andreas Loew <address@hidden>
>>
> I feel like we should be fixing diskfilter. Consider another case: dead
> disk dangling on cable and returning mostly I/O errors
Could you explain what do you mean? Removable media detection remains
valid case and cannot be solved without low level driver cooperation
anyway. If you mean some ratelimiting, this probably has to go into
core, not in diskfilter, but it looks orthogonal to this patch.