Re: [PATCH] efidisk: prevent errors from diskfilter scan of removable drives

[Andrei Borzenkov]

12.02.2016 17:49, Vladimir 'φ-coder/phcoder' Serbinenko пишет:
> On 12.02.2016 15:38, Andrei Borzenkov wrote:
>> On Fri, Feb 12, 2016 at 5:29 PM, Vladimir 'φ-coder/phcoder' Serbinenko
>> <address@hidden> wrote:
>>> On 05.02.2016 17:56, Andrei Borzenkov wrote:
>>>> Map EFI_NO_MEDIA to GRUB_ERR_OUT_OF_RANGE that is ignored by diskfilter. 
>>>> This
>>>> actually matches pretty close (we obviously attempt to read outside of 
>>>> media)
>>>> and avoids adding more error codes.
>>>>
>>>> This affects only internally initiated scans. If read/write from removable 
>>>> is
>>>> explicitly requested, we still return an error and text explanation is more
>>>> clear for user than generic error.
>>>>
>>>> Reported and tested by Andreas Loew <address@hidden>
>>>>
>>> I feel like we should be fixing diskfilter. Consider another case: dead
>>> disk dangling on cable and returning mostly I/O errors
>>
>> Could you explain what do you mean? Removable media detection remains
>> valid case and cannot be solved without low level driver cooperation
>> anyway. If you mean some ratelimiting, this probably has to go into
>> core, not in diskfilter, but it looks orthogonal to this patch.
>>
> I mean what if we have a legitimately bad disk unrelated to any
> diskfilter VGs. If diskfilter is unable to read from it, it should still
> be able to assemble VGs and skip failed disk


There is probably misunderstanding. There is no problem assembling VGs;
diskfilter prints error and continues. The purpose of this patch is to
suppress error print when there is no error (media not present is not an
error when we scan for diskfilter devices).

This was not as cosmetic because on boot from within menu it would stop
telling user to press any key if there are removable devices.

signature.asc
Description: OpenPGP digital signature