[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] configure.ac: support -fdiagnostics-color=always
|
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
|
Subject: |
Re: [PATCH] configure.ac: support -fdiagnostics-color=always |
|
Date: |
Fri, 24 Apr 2015 17:40:29 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 |
On 06.04.2015 20:24, Andrei Borzenkov wrote:
> В Mon, 6 Apr 2015 19:33:30 +0200
> Michael Zimmermann <address@hidden> пишет:
>
>> ---
>> configure.ac | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 891c14f..1f8cb2c 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -1046,6 +1046,15 @@ if test "x$grub_cv_target_cc_qn" = xyes; then
>> TARGET_CFLAGS="$TARGET_CFLAGS -Qn"
>> fi
>>
>> +AC_CACHE_CHECK([whether option -fdiagnostics-color=always works],
>> grub_cv_target_cc_fdiagnostics_color, [
>> + CFLAGS="$TARGET_CFLAGS -fdiagnostics-color=always -Werror"
>> + AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])],
>> + [grub_cv_target_cc_fdiagnostics_color=yes],
>> + [grub_cv_target_cc_fdiagnostics_color=no])])
>> +if test "x$grub_cv_target_cc_fdiagnostics_color" = xyes; then
>> + TARGET_CFLAGS="$TARGET_CFLAGS -fdiagnostics-color=always"
>> +fi
>> +
>> #
>> # Compiler features.
>> #
>
> I think it should be left to distribution/user. You can always run
>
> ./configure TARGET_CFLAGS="-Os -fdiagnostic-color=always"
>
Agreed. Especially given that stdout isn't necessarily a terminal.
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
signature.asc
Description: OpenPGP digital signature