[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug #44239] Behavior of syslinux_parse differs from SYSLINUX for in
|
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
|
Subject: |
Re: [bug #44239] Behavior of syslinux_parse differs from SYSLINUX for initrd= option |
|
Date: |
Mon, 16 Feb 2015 16:07:36 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 |
On 13.02.2015 21:32, Lunar wrote:
> Andrei Borzenkov:
>> Follow-up Comment #1, bug #44239 (project grub):
>>
>> Can't comment about behavior itself. Re. patch
>>
>> + cmdline = grub_strdup(curentry->append);
>> Error check missing.
>>
>> + grub_free(cmdline);
>> You need to delete free(cmdline) later.
>
> Both fixed.
>
>> Again, can you post updated version to grub-devel for easier review?
>
> Here it is.
>
The code at this place turned out to be not very understandable. I
simplified the code and did the change you requested.
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
signature.asc
Description: OpenPGP digital signature