[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: configure.ac: Always add -D_FILE_OFFSET_BITS=64.
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
Subject: |
Re: configure.ac: Always add -D_FILE_OFFSET_BITS=64. |
Date: |
Tue, 27 Jan 2015 17:28:43 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 |
On 26.01.2015 17:50, Andrei Borzenkov wrote:
> В Mon, 26 Jan 2015 18:12:19 +0300
> Andrei Borzenkov <address@hidden> пишет:
>
>> On Mon, Jan 26, 2015 at 6:04 PM, Vladimir 'φ-coder/phcoder' Serbinenko
>> <address@hidden> wrote:
>>> On 26.01.2015 12:29, Andrei Borzenkov wrote:
>>>>> +CPPFLAGS="$CPPFLAGS -D_FILE_OFFSET_BITS=64"
>>>>> +HOST_CPPFLAGS="$HOST_CPPFLAGS -D_FILE_OFFSET_BITS=64"
>>>>
>>>>
>>>> We already have them unconditionally in config.h. This is confusing;
>>>> may be remove them from this file. OTOH we have AC_LARGEFILES that is
>>>> expected to figure out proper options (although I believe for now
>>>> there is just one system that needs it).
>>>>
>>> Do you mean AC_SYS_LARGEFILE ? Does it actually work?
>>
>> It apparently works for other projects ...
>>
>>>
>>> How exactly does
>>> it make its way to HOST_CPPFLAGS?
>>
>> It does not, that is my point.
>
> Sorry, was wrong. It makes it way via config-util.h
>
> AC_CONFIG_HEADER([config-util.h])
>
> and
>
> /* Number of bits in a file offset, on hosts where this is settable. */
> /* #undef _FILE_OFFSET_BITS */
>
> /* Define for large files, on AIX-style hosts. */
> /* #undef _LARGE_FILES */
>
> I'm on 64 bit Linux so do not need any of these to enable large files.
> So your patch seems to be redundant and I'd consider removing them from
> config.h as well after release.
>
fuse headers need explicit _FILE_OFFSET_BITS and so we need to include
them for fuse tests. Also we need to include them for 64-bit off_t
availability tests.
signature.asc
Description: OpenPGP digital signature