Re: [PATCH 2/2] second attempt to fix using grub device name as install device

[Andrey Borzenkov]

В Sat, 07 Dec 2013 09:47:44 +0100
Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:

> On 07.12.2013 09:44, Andrey Borzenkov wrote:
> > +     install_device[grub_strlen (install_device) - 1] = '\0';
> > +     install_drive = xstrdup (install_device + 1);
> > +     install_device[grub_strlen (install_device) - 1] = ')';
> > +        }
> Bad code. You forgot that grub_strlen changes with your operations. You
> need to keep explicit pointer.
> 
> 

Oops. Any reason "our" gnulib is missing xstrndup? It is not the only
place where it will make things more simple and readable.

signature.asc
Description: PGP signature