grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] second attempt to fix using grub device name as install


From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH 2/2] second attempt to fix using grub device name as install device
Date: Sat, 07 Dec 2013 09:47:44 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9

On 07.12.2013 09:44, Andrey Borzenkov wrote:
> +       install_device[grub_strlen (install_device) - 1] = '\0';
> +       install_drive = xstrdup (install_device + 1);
> +       install_device[grub_strlen (install_device) - 1] = ')';
> +        }
Bad code. You forgot that grub_strlen changes with your operations. You
need to keep explicit pointer.


Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]