Re: [PATCH] diskfilter: Treat an unrecognized RAID level as an error

[Richard Laager]

On Sat, 2012-02-04 at 23:30 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> On 04.02.2012 23:01, Richard Laager wrote:
> > disk/diskfilter.c: In function 'grub_diskfilter_make_raid':
> > disk/diskfilter.c:847:21: error: 'totsize' may be used uninitialized in
> > this function [-Werror=uninitialized]
> >
> > Perhaps my patch should use assert() instead of return NULL?
> We don't use assert since assert failures are usually not fatal. And 
> failing to boot just because some otherwise unused disk has a RAID-9 
> isn't reasonable.

Noted. I see now that Grégoire Sutre already submitted the same fix. I
don't know how I missed that mail before. Sorry for the noise. At least
I learned about GRUB's take on assert().

-- 
Richard

signature.asc
Description: This is a digitally signed message part