grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] diskfilter: Treat an unrecognized RAID level as an error


From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] diskfilter: Treat an unrecognized RAID level as an error
Date: Sat, 04 Feb 2012 23:30:15 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0

On 04.02.2012 23:01, Richard Laager wrote:
disk/diskfilter.c: In function 'grub_diskfilter_make_raid':
disk/diskfilter.c:847:21: error: 'totsize' may be used uninitialized in
this function [-Werror=uninitialized]

Perhaps my patch should use assert() instead of return NULL?
We don't use assert since assert failures are usually not fatal. And failing to boot just because some otherwise unused disk has a RAID-9 isn't reasonable.


_______________________________________________
Grub-devel mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/grub-devel


--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko




reply via email to

[Prev in Thread] Current Thread [Next in Thread]