Re: PXE directory listing incorrectly reported as "success"

[Vladimir 'φ-coder/phcoder' Serbinenko]

Robert Millan wrote:
> Hi,
>
> It appears that directory listing isn't supported by TFTP protocol (so
> says our wiki).
>
> Our pxe.c implements grub_pxefs_dir() as a dummy stub that returns
> GRUB_ERR_NONE.  This is obviously wrong, as it prevents the user from
> noticing that there was a problem, and silently reports an "empty"
> directory.  Instead, it should call grub_error ().
>
> Unfortunately, kern/fs.c relies on grub_pxefs_dir() returning
> GRUB_ERR_NONE in order to consider probing to be succesful.  If pxe
> returned an error, it wouldn't be considered a valid filesystem by
> the kernel.
>   
> So I'm wondering, what would be a good solution to this?  
What about return GRUB_ERR_UNSUPPORTED or a separate GRUB_ERR_FS_NO_DIR
which would be ignored by probing routines?
> We could add
> a proper probe() function and switch all filesystems to it, but only
> for the benefit of pxe it seems a bit overkill.
>
> Does someone have a better idea?
>
>   


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

signature.asc
Description: OpenPGP digital signature