Re: [PATH] grub-mkrelpath

[rubisher]

On Tue, 03 Nov 2009 11:33:42 +0100, Felix Zielcke <address@hidden>
wrote:
> Am Dienstag, den 03.11.2009, 11:21 +0100 schrieb rubisher:
>> Hello Felix,
>> 
>> On Mon, 02 Nov 2009 09:54:43 +0100, Felix Zielcke <address@hidden>
>> wrote:
>> > Am Sonntag, den 01.11.2009, 23:04 +0100 schrieb Robert Millan:
>> >> On Sun, Nov 01, 2009 at 04:39:42PM +0100, Felix Zielcke wrote:
>> >> > 
>> >> > I added now a comment that this shouldn't ever happen.
>> >> > 
>> >> > New version avaible at
>> >> > bzr+ssh://bzr.savannah.gnu.org/grub/people/fzielcke/mkrelpath
>> >> 
>> [snip]
>> 
>> I am trying to build your mkrelpath branch on my ppc with debian
gcc-4.4
>> latest unstable release 4.4.2-1 and failed to build as far as I
>> understand
>> because isystem syntax is not correct; following diff help me to
complete
>> the build:
> 
> Which is the same as in trunk.
right no issue to compile trunk 2676 but as following way (svn 2676):
[snip]
gcc-4.4 -Icommands -I/SrcTree/grub2-svn2676/commands 
-isystem=/SrcTree/grub2-svn2676/include -I/SrcTree/grub2-svn2676/include 
-I. -I./include -Wall -W  -O0 -m32 -fno-stack-protector -Werror 
-ffreestanding -MD -c -o halt_mod-commands_halt.o
/SrcTree/grub2-svn2676/commands/halt.c
[snip]

> 
>> === <> ===
>> (i.e. I have to rm '=' between isystem and its arg)
>> 
>> I don't know if it's specific to ppc arch, sorry.
>> 
> 
> Seems so, because on amd64 it works fine.
> The docs say:
> 
> -isystem dir
>         Search dir for header files, after all directories specified by
>         -I but before the standard system directories. Mark it as a
>         system directory, so that it gets the same special treatment as
>         is applied to the standard system directories. If dir begins
>         with =, then the = will be replaced by the sysroot prefix; see
>         --sysroot and -isysroot. 
> 
> So it should be valid.
> Maybe with a space between -isystem and = it works for you too.
Unfortunately not but to give more details, here is how it failed
(mkrelpath tree 1802)
[snip]
gcc-4.4 -Icommands -I/SrcTree/grub2-fzibzr1802/commands 
-isystem=/SrcTree/grub2-fzibzr1802/include -I.
-I./include -Wall -W  -O0 -m32 -fno-stack-protector -Werror -ffreestanding

-MD -c -o halt_mod-commands_halt.o
/SrcTree/grub2-fzibzr1802/commands/halt.c
/Sources/jso/Grub2.deb/grub2-fzibzr1802/commands/halt.c:20:21: error:
grub/dl.h: No such file or directory
/Sources/jso/Grub2.deb/grub2-fzibzr1802/commands/halt.c:22:26: error:
grub/command.h: No such file or directory
In file included from 
/Sources/jso/Grub2.deb/grub2-fzibzr1802/commands/halt.c:25:
./include/grub/machine/kernel.h:22:25: error: grub/symbol.h: No such file 
or directory
In file included from 
/Sources/jso/Grub2.deb/grub2-fzibzr1802/commands/halt.c:25:
./include/grub/machine/kernel.h:26: error: 'EXPORT_FUNC' declared as 
function returning a function
cc1: warnings being treated as errors
[snip]
so here no more "-I/SrcTree/grub2-svn2676/include" as in svn trunk,
though.

> But now that I read that I'm not so sure we actually should use =

I will check first how it boot, then check a bit further.

Tx,
    J.