|
From: | Vladimir 'phcoder' Serbinenko |
Subject: | Re: [PATCH] Fail gracefuly when attempting to load 64-bit kFreeBSD on IA32 CPU |
Date: | Thu, 08 Oct 2009 14:17:16 +0200 |
User-agent: | Mozilla-Thunderbird 2.0.0.22 (X11/20090701) |
Felix Zielcke wrote: > Am Mittwoch, den 07.10.2009, 23:13 +0200 schrieb Robert Millan: > > >> (grub_cpuid_has_longmode): ... this. Update all users. Remove >> `unsigned' attribute. >> > > I think that should be `static' not `unsigned': > > -static unsigned char has_longmode = 0; > +unsigned char grub_cpuid_has_longmode = 0; > > But don't we need to add now an `insmod cpuid' in grub-mkconfig so that > this actually works / is useful? > Or does the cpuid command get loaded automatically somewhere already? > > It gets loaded because of symbol dependency of bsd.mod on grub_cpuid_has_longmode -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git
[Prev in Thread] | Current Thread | [Next in Thread] |