Re: [PATCH] Fail gracefuly when attempting to load 64-bit kFreeBSD on IA32 CPU

[Vladimir 'phcoder' Serbinenko]

>Index: include/grub/i386/cpuid.h
>===================================================================
>--- include/grub/i386/cpuid.h  (revision 0)
>+++ include/grub/i386/cpuid.h  (revision 0)

This file doesn't follow convention of having an ifdef around the file

>+extern unsigned char grub_cpuid_has_longmode;
I don't like it being declared as a variable: user may inadvertently assign a 
value to it. I would be more confortable with a function

Other than that patch looks good


-- 
Regards
Vladimir 'phcoder' Serbinenko
Personal git repository: http://repo.or.cz/w/grub2/phcoder.git