Re: [Fwd: Re: Bug#545460: segfault during update of grub-pc package]

[Pavel Roskin]

On Tue, 2009-09-08 at 14:58 +0200, Felix Zielcke wrote:

> > Program received signal SIGSEGV, Segmentation fault.
> > 0x080490a8 in probe_raid_level (disk=0x0) at
> > /home/work/src/grub2/util/grub-probe.c:94
> > 94        if (disk->dev->id != GRUB_DISK_DEVICE_RAID_ID)
> > (gdb) bt
> > #0  0x080490a8 in probe_raid_level (disk=0x0) at
> > /home/work/src/grub2/util/grub-probe.c:94
> > #1  0x08049293 in probe (path=0x0, device_name=0xbffffea0
> > "/dev/mapper/rhenvar-lvol0") at /home/work/src/grub2/util/grub-probe.c:167
> > #2  0x0804982f in main (argc=4, argv=0xbffffd74) at
> > /home/work/src/grub2/util/grub-probe.c:417
> 
> Should we just check if disk or disk-dev is NULL or is this a more
> serious problem where something else needs a change?

Let's not do it blindly.  probe_raid_level is called with the NULL
argument when going over the list.  We need to understand how we get
such an element in the list.  Then we can think how to fix it.

-- 
Regards,
Pavel Roskin