[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Optimised 1bit blitters
From: |
Robert Millan |
Subject: |
Re: [PATCH] Optimised 1bit blitters |
Date: |
Sun, 23 Aug 2009 12:48:12 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Fri, Aug 21, 2009 at 05:33:30PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> + for (j = 0; j < height; j++)
> + {
> + for (i = 0; i < width; i++)
> + {
It's a bit odd, but GCC doesn't seem to optimize those in a single loop. Could
you use "i = 0; i < height * width; i++" instead? (for this and the other
similar instances)
I can't comment much on the rest of this patch, as my understanding of
graphics is limited. But please wait a few days before commit, hopefully
someone else will review.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."