Re: Fwd: [PATCH 1/2] Framebuffer split

[Vladimir 'phcoder' Serbinenko]

> I would like a video_fb function like
> grub_video_fb_create_render_target_from_buffer(void * buffer, int
> allocated, const grub_video_mode_info_t * mode_info)
Well this is pretty much what we do directly. New fields can be added
to fbrender_target with no problem. (btw currently driver manages only
screen render target and completely delegates other functions to
video_fb)
> I am sure that for doing transparent rotation in video_fb
> encapsulation is good. I can do without it or patch it in with the
> rotation if I get it into working state.
Actually it's enough to follow simple rules like
blitting target on target isn't rotated but coordinates are adjusted
blitting non-target on target is rotated.
This way video adapter doesn't have to know about nature of blitting operations.
Anyway you need  to adjust width and height returned by mode_info.
A function video_fb_transform_coordinates can do this. This way
framebuffer can apply any transformation, not just rotation w/o driver
to know.
> Thanks
>
> Michal
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git