[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fwd: [PATCH 1/2] Framebuffer split
From: |
Vladimir 'phcoder' Serbinenko |
Subject: |
Re: Fwd: [PATCH 1/2] Framebuffer split |
Date: |
Thu, 13 Aug 2009 22:36:37 +0200 |
> Please go ahead (I assume it raises no warnings and it's well tested).
I tested the latest version with gfxterm and xnu loader. I use
previous version in my daily bootloader. I'll run another series of
tests before comitting.
>
> One small detail:
>
>> + grub_free (mode_list);
>> + mode_list = 0;
>
> I would prefer if we used NULL for pointers. I know we don't do that
> everywhere, but it makes code easier to understand.
>From GCS: "Zero without a cast is perfectly fine as a null pointer
constant, except when calling a varargs function. "
>
> --
> Robert Millan
>
> The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
> how) you may access your data; but nobody's threatening your freedom: we
> still allow you to remove your data and not access it at all."
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
--
Regards
Vladimir 'phcoder' Serbinenko
Personal git repository: http://repo.or.cz/w/grub2/phcoder.git
- Re: Fwd: [PATCH 1/2] Framebuffer split, (continued)
- Re: Fwd: [PATCH 1/2] Framebuffer split, Michal Suchanek, 2009/08/10
- Re: Fwd: [PATCH 1/2] Framebuffer split, Vladimir 'phcoder' Serbinenko, 2009/08/10
- Re: Fwd: [PATCH 1/2] Framebuffer split, Michal Suchanek, 2009/08/10
- Re: Fwd: [PATCH 1/2] Framebuffer split, Vladimir 'phcoder' Serbinenko, 2009/08/10
- Re: Fwd: [PATCH 1/2] Framebuffer split, Michal Suchanek, 2009/08/10
- Re: Fwd: [PATCH 1/2] Framebuffer split, Vladimir 'phcoder' Serbinenko, 2009/08/10
- Re: Fwd: [PATCH 1/2] Framebuffer split, Michal Suchanek, 2009/08/12
- Re: Fwd: [PATCH 1/2] Framebuffer split, Vladimir 'phcoder' Serbinenko, 2009/08/12
- Re: Fwd: [PATCH 1/2] Framebuffer split, Vladimir 'phcoder' Serbinenko, 2009/08/13
- Re: Fwd: [PATCH 1/2] Framebuffer split, Robert Millan, 2009/08/13
- Re: Fwd: [PATCH 1/2] Framebuffer split,
Vladimir 'phcoder' Serbinenko <=
- Re: Fwd: [PATCH 1/2] Framebuffer split, Robert Millan, 2009/08/13
- Re: Fwd: [PATCH 1/2] Framebuffer split, Michal Suchanek, 2009/08/13
- Re: Fwd: [PATCH 1/2] Framebuffer split, Michal Suchanek, 2009/08/14
- Re: Fwd: [PATCH 1/2] Framebuffer split, Vladimir 'phcoder' Serbinenko, 2009/08/14
- Re: Fwd: [PATCH 1/2] Framebuffer split, Michal Suchanek, 2009/08/14
- Re: Fwd: [PATCH 1/2] Framebuffer split, Vladimir 'phcoder' Serbinenko, 2009/08/14
- Re: Fwd: [PATCH 1/2] Framebuffer split, Vladimir 'phcoder' Serbinenko, 2009/08/14
- Re: Fwd: [PATCH 1/2] Framebuffer split, Michal Suchanek, 2009/08/12
- Re: Fwd: [PATCH 1/2] Framebuffer split, Vladimir 'phcoder' Serbinenko, 2009/08/12
- Re: Fwd: [PATCH 1/2] Framebuffer split, Michal Suchanek, 2009/08/12