Re: [PATCH] Fix hexdump not to duplicate code with kern/partition.c

[Robert Millan]

On Fri, Jul 31, 2009 at 06:26:19PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> Splitted from nested partition patch
> 
> -- 
> Regards
> Vladimir 'phcoder' Serbinenko
> 
> Personal git repository: http://repo.or.cz/w/grub2/phcoder.git

> diff --git a/ChangeLog b/ChangeLog
> index e553828..e987af6 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2009-06-08  Vladimir Serbinenko  <address@hidden>
> +
> +     * commands/hexdump.c (grub_cmd_hexdump): Use grub_disk_read instead
> +     of homegrown code.
> +

Hi,

Looks good, but I haven't tried it.  Assuming you've tested it and also builds
warning-free, I'm fine with it.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."