[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC] Don't pass filename in multiboot command line
From: |
Robert Millan |
Subject: |
Re: [RFC] Don't pass filename in multiboot command line |
Date: |
Sun, 2 Aug 2009 23:38:36 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Sat, Aug 01, 2009 at 05:13:27PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> >> > There's a much simpler way to address this. Just add something like:
> >> >
> >> > cmdline_argv = argv + 1;
> >> > cmdline_argc = argc - 1;
> >> >
> >> > at the beginning, and then use cmdline_argv and cmdline_argc instead of
> >> > correcting the off-by-one every time.
> >> Correcting the numbers is actually smaller part of the patch. The most
> >> of it is to make empty commandlines to be handled correctly (this
> >> couldn't happen previously)
> >
> > Either there's an extra argv member that is always present and we want
> > to remove, or there's the possibility that the command-line is empty.
> > AFAICS we can't have both problems.
> >
> No. Now we have an extra element that is always present and we want to
> remove but when we remove command line can be empty and code must
> handle it correctly.
Please try this patch.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
cmdline.diff
Description: Text Data
- [RFC] Don't pass filename in multiboot command line, Vladimir 'phcoder' Serbinenko, 2009/08/01
- Re: [RFC] Don't pass filename in multiboot command line, Robert Millan, 2009/08/01
- Re: [RFC] Don't pass filename in multiboot command line, Vladimir 'phcoder' Serbinenko, 2009/08/01
- Re: [RFC] Don't pass filename in multiboot command line, Robert Millan, 2009/08/01
- Re: [RFC] Don't pass filename in multiboot command line, Vladimir 'phcoder' Serbinenko, 2009/08/01
- Re: [RFC] Don't pass filename in multiboot command line,
Robert Millan <=
- Re: [RFC] Don't pass filename in multiboot command line, Vladimir 'phcoder' Serbinenko, 2009/08/02
- Re: [RFC] Don't pass filename in multiboot command line, Robert Millan, 2009/08/02
- Re: [RFC] Don't pass filename in multiboot command line, Vladimir 'phcoder' Serbinenko, 2009/08/14
- Re: [RFC] Don't pass filename in multiboot command line, Seth Goldberg, 2009/08/26
- Re: [RFC] Don't pass filename in multiboot command line, Seth Goldberg, 2009/08/26
- Re: [RFC] Don't pass filename in multiboot command line, Michal Suchanek, 2009/08/27
- Re: [RFC] Don't pass filename in multiboot command line, Robert Millan, 2009/08/28