Re: [PATCH] Fix when installing on pationless but partionable medium

[Vladimir 'phcoder' Serbinenko]

On Wed, Jul 22, 2009 at 7:22 PM, Robert Millan<address@hidden> wrote:
> On Sat, Jul 18, 2009 at 11:28:58PM +0200, Vladimir 'phcoder' Serbinenko wrote:
>> > I don't understand what you mean here.
>> Let's take a common example of cdrom. Most of the users and developers
>> are accustomed to a cdrom holding one filesystem. On macs however cds
>> are partitioned and not being able to access all the partitions is a
>> problem for end user. Such situations are probably common. If we ditch
>> has_partitions altogether the only negative side effect will be that
>> in some weird configurations unpartitioned media may appear to have
>> partitions but whole media is still accessible. Additionally it
>> simplifies and makes kernel smaller

See nopart.diff. Once Pavel's patch for partitions is committed they
can integrate nicely in util/i386/pc/grub-setup.c

>> He said: checking that bootable flags of all
>> partitions are either set (0x80) or unset (0x0) and not another value
>
> Oh, that's different.  I think it's fine provided that:
>
>  - None of the commonly used free partitioning tools uses an illegal value.
>
>  - We fail gracefully and let the user know why.

See mbr.diff

>
> --
> Robert Millan
>
>  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
>  how) you may access your data; but nobody's threatening your freedom: we
>  still allow you to remove your data and not access it at all."
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git

mbr.diff
Description: Text document

nopart.diff
Description: Text document