Re: [PATCH] Fix when installing on pationless but partionable medium

[Vladimir 'phcoder' Serbinenko]

On Tue, Jul 28, 2009 at 7:33 PM, Robert Millan<address@hidden> wrote:
> On Sun, Jul 26, 2009 at 03:54:41PM +0200, Vladimir 'phcoder' Serbinenko wrote:
>> +      for (i = 0; i < 4; i++)
>> +     if (mbr.entries[i].flag & 0x7f)
>> +       break;
>> +
>> +      if (i != 4)
>> +     return grub_error (GRUB_ERR_BAD_PART_TABLE, "bad boot flag");
>
> Why not just return directly?
>
Force of canned code written by DMA from memory to keyboard bypassing brain ;)
> --
> Robert Millan
>
>  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
>  how) you may access your data; but nobody's threatening your freedom: we
>  still allow you to remove your data and not access it at all."
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git

mbr.diff
Description: Text document