Re: [PATCH] Support FreeBSD in osdetect.lua

[Pavel Roskin]

On Tue, 2009-07-21 at 22:17 +0200, Vladimir 'phcoder' Serbinenko wrote:

> Actually this menu is done to match the default one of FreeBSD loader.
> I'm not a FreeBSD expert so I prefered to stick to the same menu as
> default bootloader.

I see.

> > The implementation could remove the original menu, or it could insert
> > entries immediately below "safe mode".  I don't know if it's possible,
> > but it could be useful.
> >
> Bean proposed something like this but I don't know his progress
> > Actually, I don't want osdetect.lua to be overengineered and overloaded
> > with intimate knowledge of different OSes.  It's an example for others
> > to extend, not a complete solution.
> We put it into our repository this means that we accept improvements.
> I also think that there will be distributions similar to Super GRUB
> Disk and other recovery tools based on osdetect.lua. Unless we provide
> a good reference osdetect.lua there will be a bitrot between such
> distributions every one neglecting some OSes

I don't fee strongly against your change.  However, I would hate to see
five lines for every Linux kernel (although it would be nice to have
safe mode for Windows in the GRUB menu).  So this should not be an
example for other OSes.

Obviously, the zfs part shouldn't go in yet.

-- 
Regards,
Pavel Roskin