grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] unused constants in i386/boot.h


From: Yves Blusseau
Subject: Re: [PATCH] unused constants in i386/boot.h
Date: Wed, 15 Jul 2009 09:36:45 +0200
User-agent: Thunderbird 2.0.0.22 (Windows/20090605)

Pavel Roskin a écrit :
On Tue, 2009-07-14 at 19:37 +0200, Robert Millan wrote:
  
On Sun, Jul 12, 2009 at 09:21:07AM -0400, Pavel Roskin wrote:
    
Quoting Yves Blusseau <address@hidden>:

      
As long as boot/i386/pc/boot.S has the variables whose offset these macros
are describing, I think it's fine to keep them.
          
I'd rather not keep the macros that are not used outside boot.S.  They  
give a wrong impression that somebody somewhere needs to know that  
offset.
      
Ok, let's remove them.  I don't feel strongly about it.
    

I'm working on a patch series that would remove unnecessary stuff and
widen the BPB.
  
Cool, i have planed to do it but if you do the job it'll be great !

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]