grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] unused constants in i386/boot.h


From: Yves Blusseau
Subject: Re: [PATCH] unused constants in i386/boot.h
Date: Sun, 12 Jul 2009 11:02:52 +0200

On Thu, Jul 09, 2009 at 10:45:43AM +0200, Yves Blusseau wrote:
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
</head>
<body bgcolor="#ffffff" text="#000000">
<div class="moz-text-flowed"
style="font-family: -moz-fixed; font-size: 13px;" lang="x- western">Here's
the patch to remove unused constants.<br>
The real constants used are GRUB_BOOT_MACHINE_KERNEL_ADDR and
GRUB_BOOT_MACHINE_KERNEL_SEG.<br>

Hi,

As long as boot/i386/pc/boot.S has the variables whose offset these macros
are describing, I think it's fine to keep them.

Btw, please include a non-HTML version in your emails :-)

--
Robert Millan

The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we
 still allow you to remove your data and not access it at all."


_______________________________________________
Grub-devel mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/grub-devel

Hi

boot/i386/pc/boot.S DON'T use this macros.

They're only defined in i386/boot.h but they are not used anywhere. The new name of this constants are GRUB_BOOT_MACHINE_KERNEL_ADDR and GRUB_BOOT_MACHINE_KERNEL_SEG. So the GRUB_BOOT_MACHINE_KERNEL_ADDRESS and GRUB_BOOT_MACHINE_KERNEL_SEGMENT (see the difference with the constants below) constants can be definitively removed, and it's better to remove them to avoid confusion.

Yves Blusseau




reply via email to

[Prev in Thread] Current Thread [Next in Thread]