Re: [PATCH] define GRUB_MOD_ALIGN to 0 on non-ieee1275 (Re: does module area require alignment? (Re: [PATCH] i386-qemu port))

[Robert Millan]

On Mon, Jun 22, 2009 at 03:43:17PM -0400, Pavel Roskin wrote:
> On Mon, 2009-06-22 at 14:31 +0200, Robert Millan wrote:
> > Well it seems that OLPC (i386-ieee1275) needs alignment, but coreboot 
> > doesn't.
> > It must be some OFW-specific oddity.
> > 
> > This patch makes the alignment ieee1275-specific on i386.
> 
> We can define GRUB_MOD_ALIGN to 1 for such architectures and keep using
> ALIGN_UP (or remove ALIGN_UP - it doesn't matter).  The value of 0 for
> GRUB_MOD_ALIGN is meaningless, but the value of 1 has a meaning - align
> to a byte boundary.

Good idea, I just did that.  I didn't remove ALIGN_UP, since it's harmless.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."